Can you tell I once played a Warrior Tank?
Naaaaaah...

:biggrin:
As long as I get a few seconds to solidify and to account for dodges/parrys/misses on a pull, Threat hasn't been an issue. But certainly in Heroics/Dungeons, some tanks are just... bad.
Seems odd that PvP would be the complaint for a Warrior tank, though. I thought Vengeance
(stacking AP buff based on incoming damage) doesn't count for player damage. Only Mobs. At least that's what I understood... Could easily be wrong since I only PvP at gunpoint, though. <shrug>
I had presumed the QQ was from PvE~ers who were crying because they are/were incapable of out damaging the Tank. I know I've heard that from my own guildmates: And to a certain extent I have to agree, since I've seen my AP numbers triple from Vengeance stacking, and (at times) still beat well geared DD's on Trash pulls.
(The trash pulls just before Atramedes can drop a damage in/out buff that makes me quite happy in the pants when I get it...)
I completely 'Get" the concept, but Vengeance just seems... really really wonky to me. It gives LOTS of threat when we don't need it
(I've seen 50K+ TPS in a raid setting, when DD's might hit 20K DPS), but it doesn't help at all when we *do* need the boost. And that's not just Warriors, but all Tanks. I'd like to see the idea revisited and better balanced.
On the positive side, Blizz are reworking War Academy to affect Devastate instead of Heroic Strike. Yah - Another nerf to HS, but Dev isn't exactly 'Devastating' in it's current form. And it's a (talented) boost to a bread and butter attack, rather than a boost to a Rage Dump.
The thing I'm a little annoyed at is the lack of scaling for Revenge: It receives a smaller coefficient from AP than other attacks, and just doesn't hit very much harder as you gear up. This doesn't make much sense to me, since one would expect a reactive ability to be very much worth using since it's not always available even if/when you have the Rage.
My other whine is that - since ProtWars are known/loved/reviled for their interrupts - I sincerely dislike the lack of Melee stats on Tank gear. And it annoys me to
(feel pressured to/have to) give up survivability just so I don't Miss (dodged, parried, Blocked) 20% of my interrupts during raid fights.
Overall, though, Warriors are in a pretty good place. So again, I can't *really* complain.
Anyways - Back to your Pally question: My guildmaster's tanking build is heavily centered around maximizing his Self~healing. You may also want to consider that, since I can tell you from personal observation it works pretty damned well - even (especially!) given that I outgear him.