An example of bad AMD driver code

Page 2 - Seeking answers? Join the AnandTech community: where nearly half-a-million members share solutions and discuss the latest tech.

BFG10K

Lifer
Aug 14, 2000
22,477
2,397
126
This is shockingly poor quality code, and such garbage needs to be called out.

 

PrinceXizor

Platinum Member
Oct 4, 2002
2,188
99
91
This is shockingly poor quality code, and such garbage needs to be called out.


This is shockingly poor quality forum posting, and such garbage needs to be called out.
 

Leadbox

Senior member
Oct 25, 2010
744
63
91
Poor old Wizzard has no luck with AMD has he? Everything from getting the slowest ryzens on the planet to the slowest radeons for review, he also has to deal with a piece of software(NOT DRIVERS) that won't disable itself when he doesn't bother to uninstall hardware properly. Hard luck Wizz:anguished:.
 

BFG10K

Lifer
Aug 14, 2000
22,477
2,397
126
First, the AMD issue isn't with the driver. It's with software included in the package. How do you not know the difference when its clearly explained in the article? The title was nothing more than click-bait for ignorant hand wavers.
Stop playing stupid semantic games. The code in question is installed alongside the driver because it's completely useless without said driver, so that makes it part of the driver package.

I actually remove drivers for devices that are no longer part of my system. Windows doesn't install them because I have automatic driver updates disabled. No because I actually monitor my system for abnormalities.
That's simply wonderful. Do you have the delusional expectation that all 500+ million Windows users world-wide do the same?

Perhaps a more rational idea might be to tell the few thousand driver developers of the world not to write dumb infinite loops that peg CPU cores, and hold them accountable when they can't even handle elementary coding practices. I was about ten years old when I discovered non-terminating infinite loops are stupid and shouldn't be done.

You only need an instalable driver to add more features beyond transport and power delivery USB has built-in.
That's exactly what we're talking about. Please do try to keep up.

iTunes won't sync the library to my iPod without said software installed. But I guess you expect the iTunes package to be uninstalled every time I don't plan having my iPod plugged in, because some incompetent programmer decided to write an infinite loop waiting for it to be plugged in.

Ya know, "to monitor my system for abnormalities". Lulz.

No because that would be stupid. Well that and disabling a device is not the same as removing it from your system, leaving the software and driver installed, and then installing another similar device to it.
You don't know what you're talking about. Disabling a device in the BIOS basically makes it not exist. That's why you get no video signal from an iGPU when you do it.

You can try to pitchfork all you want, but few on this forum accept emotional, factless arguments. Myself included. Throwing a tantrum and trying to get others on board with you is infantile and better suited for Disqus comments.
You're expending an awful lot of time defending AMD and their piss-poor driver code while blaming the user. Why is that? What exactly are you getting out of this conversation as a return on your time investment?

No programmer writes bug free code and mistakes, even boneheaded ones, slip through for any programmer at one time or another.
I never claimed otherwise. Dereferenced nullptr, outside array bounds access, thread deadlocks (etc) are all genuine mistakes and part of the job.

But an infinite loop with the only exit condition waiting for a piece of hardware being present comes under the category of incompetence, akin to using gets() for web input, or having passwords stored as plaintext.
 
Last edited:

Kenmitch

Diamond Member
Oct 10, 1999
8,505
2,248
136

Sometimes it's best to just let it go....

Maybe the code/app sucks, but in the end it's pilot error. I would have to assume that he knows better, but then there's no story in it. Publishing a article that somewhat makes you look incompetent probably isn't in a persons best interest....I'm super anal about video card swaps and wind up doing a fresh install of the OS even after using DDU once I've tested the card.
 

Leadbox

Senior member
Oct 25, 2010
744
63
91
Sometimes it's best to just let it go....

Maybe the code/app sucks, but in the end it's pilot error. I would have to assume that he knows better, but then there's no story in it. Publishing a article that somewhat makes you look incompetent probably isn't in a persons best interest....I'm super anal about video card swaps and wind up doing a fresh install of the OS even after using DDU once I've tested the card.
True that. I'm sure we can all, at least this one time, forgive the software guys at AMD for not recognizing that there are idiots out there who "hot swap" their gpus.
 

Mopetar

Diamond Member
Jan 31, 2011
7,736
5,789
136
Their testing team probably need to add the use cases of the customer switching our their GPUs and test if the Competitor GPUs work fine after. :blush:

No one's going to do that because of how time consuming that kind of testing is and how unlikely it is to actually catch anything important. It only seems like a really great idea in hindsight, but is unlikely to actually catch the next type of problem like this that actually occurs. The important thing is being able to release a fix for it when it does get identified.
 

BFG10K

Lifer
Aug 14, 2000
22,477
2,397
126
Maybe the code/app sucks, but in the end it's pilot error.
No, it really isn't. Stop blaming the user for incompetent coding. Windows automatically pulls in drivers unless you take specific steps to block it.

For someone to imply it's the responsibility of the the average Windows user to use GPO (or whatever) to block it and manually administer drivers is beyond laughable, especially since a large portion of the population has trouble even turning on their PC.
 

AnitaPeterson

Diamond Member
Apr 24, 2001
5,923
344
126
Sometimes it's best to just let it go....

Maybe the code/app sucks, but in the end it's pilot error. [...] I'm super anal about video card swaps and wind up doing a fresh install of the OS even after using DDU once I've tested the card.

QFT.

See my experience:
 

Kenmitch

Diamond Member
Oct 10, 1999
8,505
2,248
136
QFT.

See my experience:

lol....It's hit and miss in the end as you've already found out.
 

Stuka87

Diamond Member
Dec 10, 2010
6,240
2,559
136
No, it really isn't. Stop blaming the user for incompetent coding. Windows automatically pulls in drivers unless you take specific steps to block it.

For someone to imply it's the responsibility of the the average Windows user to use GPO (or whatever) to block it and manually administer drivers is beyond laughable, especially since a large portion of the population has trouble even turning on their PC.

Windows only installs drivers for hardware it detects. If you have an nVidia card, Windows is not going to automatically install AMD drivers also, or vice versa.
 

Mopetar

Diamond Member
Jan 31, 2011
7,736
5,789
136
Windows only installs drivers for hardware it detects. If you have an nVidia card, Windows is not going to automatically install AMD drivers also, or vice versa.

Seems like a lot of issues could be solved if it either uninstalled old drivers or had some other system of putting everything except an active driver or other necessary code in some kind of quarantine where it couldn't lead to a lot of these bizarre problems.
 

Hitman928

Diamond Member
Apr 15, 2012
4,795
6,918
136
QFT.

See my experience:

Try using Nvidia proprietary driver on Linux and then switching to AMD.
 

Stuka87

Diamond Member
Dec 10, 2010
6,240
2,559
136
Seems like a lot of issues could be solved if it either uninstalled old drivers or had some other system of putting everything except an active driver or other necessary code in some kind of quarantine where it couldn't lead to a lot of these bizarre problems.

The windows 10 driver install experience is overall not nice, at all. I have had it uninstall brand new drivers in order to install older drivers because the ones that Windows had access too (WHQL ones basically) were older than the latest ones. Which has lead to games regressing back to buggy or poor performing conditions. So I have had to fully disable windows being able to install drivers. Which every now and then gets re-enabled.

Its... annoying.
 

BFG10K

Lifer
Aug 14, 2000
22,477
2,397
126
Windows only installs drivers for hardware it detects. If you have an nVidia card, Windows is not going to automatically install AMD drivers also, or vice versa.
Correct, but if you change hardware (or disable it) the old drivers aren't uninstalled. Windows most certainly doesn't run DDU on itself.

It's a comically simple requirement for the driver not to fall into an infinite loop when it can't find matching hardware. There's nothing strange or exotic about this expectation.