depends on what you do with xp
but 512 is definately the sweet spot as 256 mb does get used up pretty easily
edit lets say you add 1 gb of ram but only play games or cd's surf the web etc then yes the extra 512 mb is a waste as it will hardly ever be used
but if you edit video or work with photoshop then it will definately help