The story of notfred and the excessively long "if" statement.

[notfred]

Bah, I think I confused myself 😕

if (((($y1 - $slopep * $x1 > $yp1 - $slopep * $xp1)&amp;&amp;($y2 - $slopep * $x2 < $yp1 - $slopep * $xp1))||(($y1 - $slopep * $x1 < $yp1 - $slopep * $xp1)&amp;&amp;($y2 - $slopep * $x2 > $yp1 - $slopep * $xp1)))&amp;&amp;((($yp1 - $slope * $xp1 > $y1 - $slope * $x1)&amp;&amp;($yp2 - $slope * $xp2 < $y1 - $slope * $x1))||(($yp1 - $slope * $xp1 < $y1 - $slope * $x1)&amp;&amp;($yp2 - $slope * $xp2 > $y1 - $slope * $x1))))
{
return 1;
}

And yes, it's formatted much more nicely in my actual code... but damn, it's one hell of a long 'if'.

Nicely formatted:

 

[dighn]

personally i'd break it down into boolean variables &amp; nested ifs

 

[AFB]

I think thats what boolean vars are for.

 

[AFB]

Originally posted by: dighn
personally i'd break it down into boolean variables

Hahaha, very true

like
boolean lineTooHigh = //one line of code here

 

[DaveSimmons]

Have fun if you ever need to modfiy it 🙂

That's one nice thing about compiled langauges, there's no penalty for making it legible by setting a bunch of booleans outside the if.

 

[BigJ]

Originally posted by: dighn
personally i'd break it down into boolean variables &amp; nested ifs

Makes things much more organized and easier to modify

 

[n0cmonkey]

How does this relate to doom 3?

😛

The last thing I worked on (just a bourne shell script) had enough nested ifs to confused the heck out of myself.

 

[Barnaby W. Füi]

There are these cool things called functions!

 

[kamper]

Originally posted by: BingBongWongFooey
There are these cool things called functions!

Bingo. How many times did you recalculate the same thing? There seems to be one function recoded 16 times. And you'd only have to call it 6 times by my count to consider the different inputs. But congrats for having the guts to post that and have it critiqued 😉