PHP Function/Query code

[TechBoyJK]

I'm not much of a php coder, but I'm trying to learn by building a basic webapp.

In the code below, I'm getting an error of

Call to a member function query() on a non-object in /getApplications.php on line 24

line 24 // if ($conn->query($sql) === TRUE) {

  function createApplication($firstName, $lastName, $address, $city)
  {
    $conn = mysql_connect('localhost', 'user', 'passme123!', 'jobApplications');
    // Check connection
    if ($conn->connect_error) {
      die("Connection failed: " . $conn->connect_error);
    } 
    else {
      $sql = "INSERT INTO tbl_jobApplications (firstName, lastName, address, city)
          VALUES ('$firstName', '$lastName', '$address', '$city')";

     if ($conn->query($sql) === TRUE) {  
        echo "New record created successfully";
      } 
      else {
       echo "Error: " . $sql . "<br>" . $conn->error;
      }

    }
    
    mysql_close($conn);
    
  }

I'm trying to create a function called createApplication which takes a set of arguments and inserts it into a database table. I think my overall function syntax is correct but how I'm calling the query is wrong. Also, I removed all but 4 of the arguments for sake of making code more legible.

Thoughts?

 

[TechBoyJK]

Nevermind.

I just spent some time learning about mysql_ vs mysqli_ in php

Using mysqli_ made everything work and it looks like mysqli_ is recommended for any modern development.

 

[uclabachelor]

You should be using PDO and prepared statements / parameters.

 

[brianmanahan]

pros and cons of PHP development

pros: development

cons: PHP

 

[Rakehellion]

pros and cons of PHP development

pros: development

cons: PHP

:thumbsup:

PHP is like the red-headed stepchild. You just have to hit him until he learns.

 

[beginner99]

You should be using PDO and prepared statements / parameters.

this.

OPs code is vulnerable to SQL Injection.