I am stuck in a inifnite loop and i cant get out!

[sbud34]

Trying to write Euclid's greatest denominator algorithm using recursion today, and i freaking wrote an infinte loop and i dont know how to fix it ahh!! Whoever invented recursion should be dragged out and beaten endlessly with a bamboo stick :disgust:

 

[VTBigBear]

run over it with a car...
not beat it with a bamboo stick..


recursion SUCKS..

 

[sbud34]

<< run over it with a car... not beat it with a bamboo stick.. recursion SUCKS.. >>



And stone him to death while we're at it.....

 

[ThisIsMatt]

what's so bad about it? You just gotta follow it closely...

 

[sbud34]

Two words: Inifinite loops....
btw I have been sitting here for two hours and still cant figure what's going wrong.....:disgust:

 

[FatAlbo]

Stop when the remainder is zero. Make sure you're passing the correct numbers to the next recursive step.

 

[MichaelD]

<< Euclid's greatest denominator algorithm using recursion today >>



Ya'know, it's crap like this that really pisses me off because it makes me feel STUPID. I mean, holyheadachebatman; WTF is that? The Euclid I know was a Greek philosopher not a mathematician. "Using recursion?" OMG, my head hurts...

Ripped from Dictionary.com

re·cur·sion (r-k&ucirc;rzhn)
n. Mathematics
An expression, such as a polynomial, each term of which is determined by application of a formula to preceding terms.
A formula that generates the successive terms of a recursion.


Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaamyheaddddddddddddddddddddd!

"Didn't you take Calculus, MichaelD? Bwahahaha! Math is not my thing...I'm pitifully stupid at it. I never got past HS Algebra. Really. Now, give me a topic and two minutes to think about it and I can get up in front an auditorium full of people and convince you that I actually know what I'm talking about. English/Vocabularly/Speech/Composition I"m great at..but this stuff...sheesh. Recursion my ass.

 

[ThisIsMatt]

<< Two words: Inifinite loops....
btw I have been sitting here for two hours and still cant figure what's going wrong.....:disgust: >>

You can have infinite loops w/o recursion...

 

[sbud34]

<< Stop when the remainder is zero. Make sure you're passing the correct numbers to the next recursive step. >>





I have a sentinel when remainder == 0. And In the debugger i see remainder going to zero, but the program wont freaking stop =(
9 lines of code and i can't figure out what's wrong haha

 

[PliotronX]

When I first saw this thread, I thought of DJ eN's "Life Is A Loop"

Good luck d00d

 

[ThisIsMatt]

where's your code?

 

[sbud34]

public int GCD(int x, int y)
{
int remainder = 0;
remainder = x % y;

while (remainder!=0)
{
GCD(y, remainder);
}
return y;
}

If you can figure what up with the code, i will personally set up a shrine in this 12x10 space for you

 

[Juniper]

is it that my programming sucks or is it that u did not assign a value for y to return

 

[sbud34]

the value that y returns will be whatever the y value is when remainder == 0.

 

[ThisIsMatt]

Sorry for taking so long...

The problem with your solution is that your while loop operates on the previous remainder value. For example, if you start with the two numbers '7' & '6', your first remainder will be 7%6= 1, so it will enter the loop. Now your values being passed are '6' & '1', and their remainder is '0' and that step will not enter the while loop, BUT when it comes back into the previous while loop and resumes that one, the current instance of remainder is still 0.

You need to change your while loop into an if statement.

 

[darkshadow1]

try replacing while with an if statement

Also, you do need to set something equal to whatever GCD returns...

public int GCD(int x, int y)
{
int remainder = 0;
remainder = x % y;

if (remainder!=0)
{
y = GCD(y, remainder);
}
return y;
}

That should do the trick...i'm mad tired though so maybe not.


Bah! I've been beaten to..oh well, I was nice and did the corrections for you...I think...but next time no code for you!

 

[ThisIsMatt]

oh, and yeah it still doesn't work 100% correctly...for example, plug in 139 & 6...it spits out 6...needs to spit out 1...

 

[ElPool]

<< Trying to write Euclid's greatest denominator algorithm using recursion today, and i freaking wrote an infinte loop and i dont know how to fix it ahh!! Whoever invented recursion should be dragged out and beaten endlessly with a bamboo stick :disgust: >>





int recursion(){

beat whoever invented recursion with bamboo stick();
recursion();

}

 

[ThisIsMatt]

public int GCD(int x, int y)
{
int remainder = x % y;

if (remainder!=0)
{
y = GCD(y, remainder);
}
return y;
}

 

[pillage2001]

<< public int GCD(int x, int y)
{
int remainder = x % y;

if (remainder!=0)
{
y = GCD(y, remainder);
}
return y;
} >>



WoHoooo......5 million dollar code.

 

[ThisIsMatt]

<<

<< public int GCD(int x, int y)
{
int remainder = x % y;

if (remainder!=0)
{
y = GCD(y, remainder);
}
return y;
} >>



WoHoooo......5 million dollar code. >>

Hey, dirty, baby I got your money, doncha worry, said hey, baby I got your money...

you gimme your number
I'll call you up
...

 

[Maximin]

>>>i]I am stuck in a inifnite loop and i cant get out![/i]

Groundhog Day?

 

[sbud34]

matt you now have a personal shrine in my drom room.....send pics over and i'll post them on my wall hah

 

[sbud34]

<<

<< Trying to write Euclid's greatest denominator algorithm using recursion today, and i freaking wrote an infinte loop and i dont know how to fix it ahh!! Whoever invented recursion should be dragged out and beaten endlessly with a bamboo stick :disgust: >>

int recursion(){ beat whoever invented recursion with bamboo stick(); recursion(); } >>




ROFLMAO!

 

[Zach]

Wussies. I just did four weeks of a course using Lisp, with imperitive programming disallowed.