Honestly you'd get the same/better results with some whey and maybe BCAA. Looking at the nutritional info they're mostly electrolyte and B12 drinks aside from a few that have BCAA's and some whey. I didn't look too much into them aside from their nutrition info on their website, some of the drink have more carbs in a serving than I eat in a day, granted I'm on a low carb diet but if you're not an athlete and are trying to lose weight they might interfere with weight loss.
If it's not more expensive than whatever you're taking now I'd say give it a shot, it doesn't look bad, just keep the above in mind. Especially if they're expensive.
Make sure you're looking at Herbalife 24, not just the regular Herbalife protein shakes. "Herbalife 24" just came out last week, and it's targeted toward cardio-based athletes and strength-based athletes, and they have kits for both. Obviously, the cardio kit is going to contain more carbohydrates than the strength kit. Here's the nutrition information for one of the components of the strength kit:
http://catalog.herbalife.com/US/en/pdf/catalog/110524_SKU1417_label_us.pdf
Pulled from the website:
-24 g whey and casein proteins create a rapid and sustained protein-building state*
-Tri-core protein-amino blend of free amino acids, whey and casein proteins help rebuild muscle and speed recovery*
-Iron essential for red blood cell protection*
-Branched-chain amino acids (BCAAs) support muscle growth*
-L-glutamine supports immune function and promotes muscle repair*
Looks to me like your friend, is not really your friend - trying to sell you this junk to make a profit. Probably trying to cut his losses short having bought a "starter kit". ; ) I wouldn't do that to my friend.
The thing is, he really believes in the stuff. It's not like he thinks its a scam and he's trying to sell me anyway. As George Castanza once said - "It's not really a lie if you believe it".