Can't find where this </br> is coming into a link.

[neogrant]

Can't find where this </br> is coming into a link.

<?php
if(isset($_POST['submit'])) { //execute only if an item is posted.
$name = preg_replace('~([^a-zA-Z])~','',$_POST['name']) . "\n"; //strip out all but alpha characters in the posted name.
$file = fopen('names.txt','a'); //open file('names.txt') or create if it doesn't exist.
fwrite($file,"<a href='http://xwis.net/ra2/players/$name'>".$name."</a>"); //write the name to the end of the file.
fclose($file); //close the file.
}
echo implode('<br />',file('names.txt'));  //print the contents to the page, one name per line.
?>
<form action="" method="post">
<label>Name: </label><br />
<input type="text" name="name" value="" /><br />
<input type="submit" name="submit" value=" Submit " />
</form>

 

[Ken g6]

Don't see a /b, but the ' . "\n"' at the end of line 3 looks a little weird. You really want a newline at the end of every $name, before "</a>"? Perhaps you want it after the "</a>"?

Edit: Is there a reason a simple '[^a-zA-Z]' doesn't work in the preg_replace?

 

[Crusty]

Not sure what you are asking really, but from your rather cryptic question I can only guess that the value of $name isn't what you are expecting at some point. Try printing the value of $name before and after you run your regex on it to see where the problem might be.

 

[neogrant]

Sorry, as you can see when you submit a name like neogrant to this http://webisol.com/xwis/submit/

it has a </br> in the url.

 

[troytime]

you're pulling the text file in as an array. every line of the txt file will be an array element.

the first few lines of your txt:
<a href='http://xwis.net/ra2/players/test
'/>test
</a><a href='http://xwis.net/ra2/players/wqewqe
'/>wqewqe
</a><a href='http://xwis.net/ra2/players/neo
'/>neo
</a><a href='http://xwis.net/ra2/players/neo
/'>neo
You then implode each element with a <br />, which is producing malformed html.
<a href='http://xwis.net/whatever<br />'/>neo<br /></a>

1. looks like the code you pasted isn't the exact code on your site.
2. why are you adding the closing slash in your <a> tags? isn't the </a> after the anchor text enough?

 

[neogrant]

the code is the same. I don't know i'm new to php.

I just want:

A form, that submits a name, that is also a link. That updates as a txt doc and displays on the page like it does.
The link is http://www.xwis.net/players/ra2/(name)

 

[CoinOperatedBoy]

As suggested, do not concatenate the name with '\n'. You'll want the newline at the actual end of the line in your output document. Also, since you're already using double quotes to evaluate $name, I don't think you need to do a string concatenation with the . operator. See:

$name = preg_replace('~([^a-zA-Z])~','',$_POST['name']); //strip out all but alpha characters in the posted name.

fwrite($file,"<a href='http://xwis.net/ra2/players/$name'>$name</a>\n");

 

[neogrant]

Thanks, that did it!

Is there a way to put in a check function to see if a duplicate has been posted?

http://www.webisol.com/xwis/submit/

 

[CoinOperatedBoy]

Thanks, that did it!

Is there a way to put in a check function to see if a duplicate has been posted?

http://www.webisol.com/xwis/submit/

You would probably have to load the file and parse it to get an array of names that you can search.