Arbitrary (javascript) code injection allowed through profile page

Page 2 - Seeking answers? Join the AnandTech community: where nearly half-a-million members share solutions and discuss the latest tech.

Crusty

Lifer
Sep 30, 2001
12,684
2
81
Where the hell is Derek Wilson and why is this still an issue? There's no excuses for this kind of security hole, period. There's also no excuse for why the transition to VB is taking so long as well. Does Derek actually care enough about the forums to fix it? If not, I suggest Anand finds someone who is willing to put in the effort required to keep the forums running securely and bug free(is that too much to ask for?).

It's only a matter of time before someone exploits this hole in a serious manner and when that happens everyone knows shit will hit the fan around here.

 

mb

Lifer
Jun 27, 2004
10,233
2
71
Sad thing is even someone like me with very little coding/scripting knowledge can do damage. I'd hate to think what someone could do with malcontent and more skill.
When I was fooling around with the avatars I messed up on something and found that every thread I posted in no longer showed replies after mine. I quickly changed it because I certainly didn't feel like being perma banned for it, but come on, look at what a simple typo can do!
 

BlueWeasel

Lifer
Jun 2, 2000
15,944
475
126
Originally posted by: Platypus
Originally posted by: oldsmoboat
If our personal PCs are at risk we should all log out till it's fixed.

olds, just install noscript for AT.

I just installed it. Is that all or does it need to be configured?
 

Crono

Lifer
Aug 8, 2001
23,720
1,503
136
Originally posted by: BlueWeasel
Originally posted by: Platypus
Originally posted by: oldsmoboat
If our personal PCs are at risk we should all log out till it's fixed.

olds, just install noscript for AT.

I just installed it. Is that all or does it need to be configured?

Default settings protect you. You will need to allow certain sites that you trust to run scripts (bar at bottom of firefox lets you nknow when noscript is blocking stuff), otherwise certain features will be disabled on those sites.
 

natto fire

Diamond Member
Jan 4, 2000
7,117
10
76
So before there were just a few minor annoyances with this crap, but now it can actually harm your computer? And people browse this place at work? I hadn't installed noscript because I thought I avoided shady websites enough that it wasn't worth the headache of configuring Noscript to work with the sites I actually use. Guess I was wrong.
 

EagleKeeper

Discussion Club Moderator<br>Elite Member
Staff member
Oct 30, 2000
42,589
5
0
Originally posted by: Platypus
Originally posted by: oldsmoboat
If our personal PCs are at risk we should all log out till it's fixed.

olds, just install noscript for AT.

Anything exist for IE?

 

Platypus

Lifer
Apr 26, 2001
31,046
321
136
Admins/mods, is it possible to get in touch with people who can make decisions to move forward with some semblance of a fix or upgrade?

Honestly the forums should go offline until this is fixed.. there's potential for some serious shit to go down.
 

EagleKeeper

Discussion Club Moderator<br>Elite Member
Staff member
Oct 30, 2000
42,589
5
0
Originally posted by: Platypus
Admins/mods, is it possible to get in touch with people who can make decisions to move forward with some semblance of a fix or upgrade?

Honestly the forums should go offline until this is fixed.. there's potential for some serious shit to go down.

FuseTalk has been notified.

Remember that for every bug fix that they handle; two more usually are generated :(
Lousy track record on their part.

 

Platypus

Lifer
Apr 26, 2001
31,046
321
136
Originally posted by: Common Courtesy
Originally posted by: Platypus
Admins/mods, is it possible to get in touch with people who can make decisions to move forward with some semblance of a fix or upgrade?

Honestly the forums should go offline until this is fixed.. there's potential for some serious shit to go down.

FuseTalk has been notified.

Remember that for every bug fix that they handle; two more usually are generated :(
Lousy track record on their part.

Yeah I'm honestly surprised they're still in business... hopefully they can address the timewarps too.
 
Oct 27, 2007
17,009
5
0
Originally posted by: Crono
...Assuming it would be fixed quickly by AT staff...

Hahahahahhahahahaha! Aaaaahhhahahahaha!

AnandTech Forums is Switching to vBulletin -- UPDATE YOUR EMAIL ADDY - 09/04/2008 12:11 AM

Hi Everyone

We are moving away from FT and adopting vB for our forum. I don't have a hard deadline yet, as there is still a lot of work to be done. Just doing the import from FT takes about two days, so there will be some down time. We still have some technical issues to work out, and the best I can do on a general time frame is sometime between the end of this month and the end of the year. I'll be hugely surprised if we are able to move faster than that, and I'll be very disappointed if it takes longer ... so there that is.
 

SunnyD

Belgian Waffler
Jan 2, 2001
32,675
146
106
www.neftastic.com
How to temporarily shield yourself from any malicious exploits that may come of this hack in the meantime:

#1 - Best bet, use Firefox + NoScript, as had been mentioned already. This is the best possible combination for all sites, not just AT. Note, this will not prevent any buffer overruns caused by malicious images, but that's a browser security issue, so make sure your browsers are up to date.

#2 - NoScript does NOT exist for IE or Chrome, and I don't believe it exists for Safari or Opera either. Other browsers, well you're on your own.

#3 - IF you use IE, please take the time to upgrade to IE8 unless you're required to use an older version. I know most companies have validated IE7 by now, so you should be running at least that. In the mean time, if you're paranoid enough, you can disable scripting support completely (but not selectively) in IE under the Internet Options > Security tab. Scroll down until you see Active Scripting and set to either disabled or prompt (which gets you as close to selective blocking) as you can get. Note, this will not disable all scripts, but it will stop a lot of the simpler exploits from happening. This information should be good for IE6/7/8, god forbid you're running anything older than that.

#3.5 - IE8 does have some support to prevent and/or notify when a site is trying to use cross-site scripting (XSS). This would give you the potential to stop it before it happens without fully disabling scripting in the browser. I haven't tested it though, so I can't tell you how well it works.

#4 - IE8 and Chrome both have "anonymous browsing" modes, which basically puts your browser in an "isolated" environment for that and only that session, preventing any sharing of cookies and such from that session. You can enable this mode for a given session, and use that browser instance to browse AT. That doesn't mean you CAN'T get hijacked while in this mode, but it does limit what can be hijacked (only the private session data). Of course, because of this, you want to make sure that you ONLY visit AT in that particular session and nowhere else prior or post, because anything else you do during that session CAN be hijacked.

#5 - Chrome has a much better sandbox than IE8 does - each tab is its own process. So in most cases, even if an exploit manages to take down a particular browser instance, with Chrome it's MUCH less likely to exploit the whole browser and further your entire computer. I'm not advocating Chrome here, I'm just saying it's safer than IE8 if you're into that sort of thing. Firefox + NoScript imho is the best interim solution.

#6 - Sorry Safari and Opera users, I'm not as familiar with those browsers, so I can't tell you what to do. The only thing I can say is they should be similar to IE in that you can disable scripting support in order to patch this little hole. I think the latest version of Safari added some XSS mitigation, but can't be sure. I haven't touched Opera in about 13 years, so I can't tell you a thing about it.

------

Finally, as far as those complaining about it needing to be fixed, yes, you're absolutely right. Due to the nature of the design of FuseTalk though, it's not an easy fix for one person (like Derek) to slap together, as to properly fix it means changing a lot of how FuseTalk works all the way down to the database level. Certain little things can be done to mitigate it, but nothing short of overhauling how the forum front end (particularly the user profile page) talks to the database here and how the image URLs are stored/referenced will prevent the ability to insert errant text and possibly malicious scripts. It's not as simple as capping off < and />. The point is the mechanism that allows selection of avatars uses plain text to reference the avatar, and as such allows plain texts to be inserted into the database, and because of WHAT it is is exposed to the entire user base. A true fix would require this mechanism to change to something that doesn't use plain text and is VALIDATED by the back end, and this is particularly why this exploit is currently possible - because it isn't validated at all.

My suggestion in the mean time is that users do their due diligence to keep these boards running until either a back end fix happens (unlikely) or vB goes live (which will present hackers a whole new set of fun toys to play with). Lets cut the mods and Derek some slack here, because there's only so much THEY can do. I believe it was mentioned elsewhere that the boards only exist because the community is a good thing and out of the goodness of Anand's heart, not because it's a money maker.

And the last thing to note is that this is FuseTalk's issue. FuseTalk is riddled with holes like this, which is part of the reason why the boards are going to vB I'm sure. I'm sure this little exploit works even on AMD's forums (which are FuseTalk powered), so don't think it's just us.

Hopefully I've helped a bit, and anyone that doesn't feel safe can use my hints as listed above to help them out till they get us moved to vB.

PS - No, I'm not LoKe, and no, this wasn't my exploit, though I realized quite rapidly how dangerous it could get (and brought it to the mods' attention - yep, I'm a narc).
 

Crono

Lifer
Aug 8, 2001
23,720
1,503
136
I agree with everything you said SunnyD, except that Anand isn't running the forums solely out of the goodness of his heart.
Forum ads do make him some cash (yes, there are ads if you don't have ABP) and the community partly supports visitors to the main site. I probably wouldn't visit the AT mainsite that often if I weren't an active poster here, and IIRC I found this site first through the forums, like many other people.

I'm not saying anything bad about Anand, just that he does gain from AT forums, and thus should at least have some interest in keeping it secure and functioning well.
 

olds

Elite Member
Mar 3, 2000
50,129
781
126
Originally posted by: SunnyD
... Due to the nature of the design of FuseTalk though, it's not an easy fix for one person (like Derek) to slap together, as to properly fix it means changing a lot of how FuseTalk works all the way down to the database level. ...
Easy fix, nuke it from orbit and go to vB.

 
Oct 27, 2007
17,009
5
0
Originally posted by: oldsmoboat
Originally posted by: SunnyD
... Due to the nature of the design of FuseTalk though, it's not an easy fix for one person (like Derek) to slap together, as to properly fix it means changing a lot of how FuseTalk works all the way down to the database level. ...
Easy fix, nuke it from orbit and go to vB.

Best suggestion yet. :thumbsup:
 

Crono

Lifer
Aug 8, 2001
23,720
1,503
136
Originally posted by: oldsmoboat
Originally posted by: SunnyD
... Due to the nature of the design of FuseTalk though, it's not an easy fix for one person (like Derek) to slap together, as to properly fix it means changing a lot of how FuseTalk works all the way down to the database level. ...
Easy fix, nuke it from orbit and go to vB.

That would be the easiest and least buggy way.
And it's the only way to be sure.
 

olds

Elite Member
Mar 3, 2000
50,129
781
126
Originally posted by: Crono
Originally posted by: oldsmoboat
Originally posted by: SunnyD
... Due to the nature of the design of FuseTalk though, it's not an easy fix for one person (like Derek) to slap together, as to properly fix it means changing a lot of how FuseTalk works all the way down to the database level. ...
Easy fix, nuke it from orbit and go to vB.

That would be the easiest and least buggy way.
And it's the only way to be sure.

I think it's only fitting that I get to be the one to push the button...
 

Crusty

Lifer
Sep 30, 2001
12,684
2
81
Originally posted by: oldsmoboat
Originally posted by: Crono
Originally posted by: oldsmoboat
Originally posted by: SunnyD
... Due to the nature of the design of FuseTalk though, it's not an easy fix for one person (like Derek) to slap together, as to properly fix it means changing a lot of how FuseTalk works all the way down to the database level. ...
Easy fix, nuke it from orbit and go to vB.

That would be the easiest and least buggy way.
And it's the only way to be sure.

I think it's only fitting that I get to be the one to push the button...

Who's going to press the other button though?

/shifty eyes
 

Newbian

Lifer
Aug 24, 2008
24,779
882
126
Originally posted by: Crusty
Originally posted by: oldsmoboat
Originally posted by: Crono
Originally posted by: oldsmoboat
Originally posted by: SunnyD
... Due to the nature of the design of FuseTalk though, it's not an easy fix for one person (like Derek) to slap together, as to properly fix it means changing a lot of how FuseTalk works all the way down to the database level. ...
Easy fix, nuke it from orbit and go to vB.

That would be the easiest and least buggy way.
And it's the only way to be sure.

I think it's only fitting that I get to be the one to push the button...

Who's going to press the other button though?

/shifty eyes

Rossman will be called out of retirement for just that.
 

skace

Lifer
Jan 23, 2001
14,488
7
81
Noscript sanitizes bad XSS calls. Users should protect themselves first instead of waiting for admins to update their stuff. Just a thought.
 

SparkyJJO

Lifer
May 16, 2002
13,357
7
81
Maybe we just need to get over to vbulletin already.

Honestly, I've seen more security bugs and holes in fusetalk since I've been here than any other forum that uses vbulletin.