Why doesn't this work? (VB 6.0 question)

[NTB]

MAXGENERATIONS=10,000 (constant declared at begining of program)

Generations = 10,000 (default; set when program starts)

Private Sub cmdGenerations_Click() 'allows user to change # of generations

Generations = InputBox("Enter number of generations:" & _
vbCrLf & "(Max = " & MAXGENERATIONS & ")", _
"Generations", MAXGENERATIONS)

If Generations < 1 Or Generations > MAXGENERATIONS Then Generations = MAXGENERATIONS

End Sub

If I input a negative number or a number > 10000, it stays there. The if statement should catch it and change it to 10k, but for some reason it doesn't. Any ideas?

Nate

 

[MrChad]

You're missing an "End If"

 

[NTB]

Originally posted by: MrChad
You're missing an "End If"

Don't need it for a single-line if. In fact, sticking an end-if in there spits out a compile error: end if without block if

 

[igowerf]

It seems to work for me, although in my test program, I have Generations and MaxGen declared within the function. Maybe it has something to do with the scope of your variables. How did you declare the global variables?

 

[MrChad]

Originally posted by: NTB

Originally posted by: MrChad
You're missing an "End If"

Don't need it for a single-line if. In fact, sticking an end-if in there spits out a compile error: end if without block if

I stand humbly corrected 🙂

 

[NTB]

Originally posted by: igowerf
It seems to work for me, although in my test program, I have Generations and MaxGen declared within the function. Maybe it has something to do with the scope of your variables. How did you declare the global variables?

It does work - I just tried it in it's own, independent little program. Time to look elsewhere; it must be something else somewhere in the program. The question now is, where?. 😕

 

[igowerf]

How are you outputting the value of Generations? Is there another function that changes its value?

 

[NTB]

Originally posted by: igowerf
How are you outputting the value of Generations? Is there another function that changes its value?

It is used in two other areas: once to control a loop, and once to set an ouput color for something on the screen. The loop is For gen = 1 to Generations; the output one looks like this: ColorNum = Generations Mod 6.

I don't think either of these are affecting it, or I would be getting some really weird results. The program works perfectly if I put in anything >=1. If I put in anything less, it just acts like nothing happened. I can click on the Generations button and set it to another number, and it's ready to go.

Nate