good sound(no one likes to hear static crackles)
capacity(imo, get a hard drive based mp3 player,has higher capacity)
music management(there's nothing more irritating than scrolling through 100 songs just to play your favourite song)
and, last battery life(some players only last 3-4 hours,better to get one with a long battery life)