Variable is breaking my js script

[TechBoyJK]

I have this script that works fine until I add a particular variable to the string

$.getJSON("http://mydomain.at/config/cfc/images.cfc?method=makeProfilePic&userID="+ #getImageInfoResults.userID# +"&thumbnailServer="+ #getImageInfoResults.imageServer# +"&thumbnailFolder="+ #getImageInfoResults.folderID# +"&thumbnailFile="+ #getImageInfoResults.imageFile#,function(result){

Everything between ## is a coldfusion variable.

The last segment is what breaks it '"&thumbnailFile="+ #getImageInfoResults.imageFile#'

I narrowed it down to '#getImageInfoResults.imageFile#' is what's breaking it.

It's just a filename. I checked the variable and for a particular instance it's '38196830020_large.jpg'

So if I put that string place of the variable it breaks too. If I remove the '.' then it's fine.

Soooooo

Do I need to encode this variable? wrap the string differently?

 

[PhatoseAlpha]

Is there an error message in the browser's error console? What behavior are you seeing on failure exactly?

 

[GregGreen]

Is there an error message in the browser's error console? What behavior are you seeing on failure exactly?

I have the same questions. Nothing you posted should break it from what I can tell.

Also, I'm curious what the ColdFusion output looks like after it's plopped in those variables. Without knowing that, can't tell if we are diagnosing a JS/jQuery problem or a CF problem.

 

[TechBoyJK]

I have the same questions. Nothing you posted should break it from what I can tell.

Also, I'm curious what the ColdFusion output looks like after it's plopped in those variables. Without knowing that, can't tell if we are diagnosing a JS/jQuery problem or a CF problem.

Everything does work if I remove that last variable reference.

&thumbnailFile="+ #getImageInfoResults.imageFile#

Actually, it still works even with

&thumbnailFile="

The output of the variable is a filename. If I replace

#getImageInfoResults.imageFile#

with

myfilename.jpg

It breaks.

If I remove the '.' it works

myfilenamejpg

So I have to believe the . is breaking

 

[Train]

URL encode the dot

%2E

I think.

 

[Dratickon]

You need to put the CF variable within the quotes.

"&thumbnailFile="+ #getImageInfoResults.imageFile#

Should be

"&thumbnailFile=#getImageInfoResults.imageFile#"

I'm also assuming that you've wrapped it with cfoutput. What looks to be happening is that your JS code is being interpreted as if myfile.jpg is a JS object written in dot notation. I'd imagine this might be happening anywhere that you're spitting out non-integer strings from CF into JS.

I'd also suggest passing in your url variables to getJSON using the object method rather than building your url string manually so everything gets url encoded.