Using GD library (PHP). What am I doing wrong?

[Gerbil333]

I'm trying to use this script. My server has PHP 5 and GD is enabled, but the script isn't working...

I removed spaces from all instances of "< ?" and " ?>". Is there something else I need to do?

<?php
if ($_POST['tempBox'] != '')
{
   // width and height of graph.  These could also be user defined values.
   $GLOBALS['width'] = 500;
   $GLOBALS['height'] = 500;
 
   // drawGrid draws X and Y axis with markers every 50 points
   // We pass in the image resource to draw to
   function drawGrid($passGraphic)
   {
      // Grid is grey
      $gridColor = imagecolorallocate($passGraphic, 200, 200, 200);
 
      // Draw two lines, one vertical in the middle of the grid (width/2)
      // and another horizontal in the middle of the grid (height/2)
      imageline($passGraphic, $GLOBALS['width']/2, 0, $GLOBALS['width']/2, $GLOBALS['height'], $gridColor);
      imageline($passGraphic, 0, $GLOBALS['height']/2, $GLOBALS['width'], $GLOBALS['height']/2, $gridColor);
 
      // Draw a marker ever 50 points on the X axis.  We do this by starting at the center
      // of the board, then incrementing 50 with every iteration.  We also
      // draw a mark in the mirror location to cover the negative side of the axis
      for ($lcv = 0 ; $lcv <$GLOBALS['width'] / 2 ; $lcv += 50)
      {
           // Set tempX and tempY to the current marker location
           $tempX = $lcv;
           $tempY = 0;
 
           // Convert to image coordinates
           cartToPixels($tempX, $tempY);
 
           // Draw the line
           imageline($passGraphic, $tempX, $tempY - 10, $tempX, $tempY + 10, $gridColor); 
 
           // Now do the same for the negative side of the axis
           $tempX = $lcv * -1;
           $tempY = 0;
           cartToPixels($tempX, $tempY);
           imageline($passGraphic, $tempX, $tempY - 10, $tempX, $tempY + 10, $gridColor);
      } 
 
      // We use the same method for drawing markers on the Y axis.
      for ($lcv = 0 ; $lcv <$GLOBALS['height'] / 2 ; $lcv += 50)
      {
           $tempX = 0;
           $tempY = $lcv;
           cartToPixels($tempX, $tempY);
           imageline($passGraphic, $tempX - 10, $tempY, $tempX + 10, $tempY, $gridColor);
           $tempX = 0;
           $tempY = $lcv * -1;
           cartToPixels($tempX, $tempY);
           imageline($passGraphic, $tempX - 10, $tempY, $tempX + 10, $tempY, $gridColor);
      } 
 
   }
 
   // cartToPixels converts Cartesian coordinates to image coordinates.  In our program
   // they are 1 to 1, though you could easily put a coefficient in to scale it up/down.
   // The two gotchas are, coordinates start from the center, and the Y axis goes in the
   // opposite direction (image coordinates, increase in Y goes down.  Cartesian, increase
   // in Y goes up).
   function cartToPixels(&$passX, &$passY)
   {
      // Start from the middle, otherwise 1 to 1 for X
      $passX = $GLOBALS['width'] / 2 + $passX;
 
      // Start from the middle, also subtract to flip for Y
      $passY = $GLOBALS['height'] / 2 - $passY;
 
   }
 
   // pixelsToCart converts from image coordinates to
   // Cartesian coordinates.  Uses the same process as
   // above but reversed.
   function pixelsToCart(&$passX, &$passY)
   {
      $passX = $passX - $GLOBALS['width'] / 2;
      $passY = $passY + $GLOBALS['height'] / 2;
   }
 
   // The plot function simply takes Cartesian coordinates and
   // plots a dot on the screen
   function plot($passGraphic, $passCartX, $passCartY)
   {
      // We use green for our graphs
      $plotColor = imagecolorallocate($passGraphic, 0, 255, 0);
 
      // Convert Cartesian coordinates to image coordinates
      cartToPixels($passCartX, $passCartY);
 
      // Then draw a dot there
      imagesetpixel($passGraphic, $passCartX, $passCartY, $plotColor);
   }
 
   // Push out an image/png mime type to the browser so it knows
   // a PNG image is coming and not HTML
   header ("Content-type: image/png");
 
   // Create a new image resource with the dimensions dictated
   // by our width and height globals.  Starts off with a black
   // background automatically.
   $im = @imagecreatetruecolor($GLOBALS['width'], $GLOBALS['height'])
      or die("Cannot Initialize new GD image stream");
 
   // Draw the grid on our graph first (under everything)
   drawGrid($im);
 
   // We start a loop from 0 (First pixel in width of graph) to the width end,
   // converting image X coordinate to Cartesian X coordinate, then retrieving
   // the corresponding Y Cartesian coordinate (remember, our equations are
   // in 'y =' form.  We multiply it by 50 to give a better resolution - e.g. multiple dots on
   // the Y axis for each X.  This gives us a solid line instead of a bunch of dots for steep
   // functions.  The higher the number, the smoother the line (and the slower the program)
   for ($lcv = 0 ; $lcv <$GLOBALS['width'] * 50 ; $lcv++)
   {
      // Get the left most point on the graph in Cartesian coordinates
      $tempX = 0;
      $tempY = 0;
      pixelsToCart($tempX, $tempY);
 
      // Now get the current Cartesian X coordinate by adding our current loop
      // value divided by 50
      $tempX += $lcv/50;
 
      // Here's where the magic happens.  In a nutshell, we're setting the Y coordinate
      // ($tempY) in relation to the current X coordinate ($tempX)
      // by using the expression specified by the user.  We use PHP's eval function,
      // which allows us to take a string (the user's input box) and run it as if it
      // were PHP code.  We're also converting X to $tempX because that's the actual
      // name of our X variable in our code, not just
      // 'X' - but we don't want the user to have to type '$tempX', so we make it easy for
      // them.  This is the line of code to be especially careful of, as a user could insert
      // malicious PHP code and do bad things.
      @eval("\$tempY = " . str_replace('X', '$tempX', $_POST['tempBox']) . ";");
 
       // Now that we have both coordinates, we plot it!
      plot($im, $tempX, $tempY);
   }
 
   // We write the equation on the graph in red
   $textColor = imagecolorallocate($im, 255, 0, 0);
 
   // Now write the equation on the graph
   imagestring($im, 4, 10, $GLOBALS['height'] - 25, 'y = ' . $_POST['tempBox'], $textColor);
 
   // Output a PNG file now that it's all built
   imagepng($im);
 
   // Free up the resource
   imagedestroy($im);
}
else
{
?>
 
<html>
   <body>
<div style="margin-bottom:20px; font-weight:bold; font-size:16px">Simple Grapher</div>
<form id="graphForm" action="?<?php echo rand(); ?>" method="post">
         Enter expression: y =
<input type="input" id="tempBox" name="tempBox">
<input type="submit" value="Graph!">
      </form>
<div style="margin-bottom:15px">Enter expression using variable X (PHP code accepted).  Both axes in range of -250 to 250.</div>
<div>Examples:
<ul>
<li><a href="javascript:populate('cos(X / 30) * 50')">cos(X / 30) * 50</a></li>
<li><a href="javascript:populate('pow(X / 30, 3) - X')">pow(X / 30, 3) - X</a></li>
<li><a href="javascript:populate('pow(X, 2) / 15 - 200')">pow(X, 2) / 15 - 200</a></li>
<li><a href="javascript:populate('2000 / X')">2000 / X</a></li>
<li><a href="javascript:populate('tan(X/ 25) * 20')">tan(X/ 25) * 20</a></li>
<li><a href="javascript:populate('-3 * X + 50')">-3 * X + 50</a></li>
<li><a href="javascript:populate('rand() % X')">rand() % X</a></li>
<li><a href="javascript:populate('pow(X,2) % X - X')">pow(X,2) % X - X</a></li>
<li><a href="javascript:populate('pow(X,2) % X - cos(X/20) * 40')">pow(X,2) % X - cos(X/20) * 40 (favorite)</a></li>
</ul></div>
 
   </body>
</html>
 
<script type="text/javascript">
 
   function populate(passExpression)
   {
      document.getElementById('tempBox').value = passExpression;
      document.getElementById('graphForm').submit();
   }
 
</script>
 
<?php
}
?>

 

[Ka0t1x]

There's a line that looks like this:
<form id="graphForm" action="?<?php echo rand(); ?>" method="post">

And it needs to look something like this:
<?php echo '<form id="graphForm" action="?'.rand().'" method="post">'; ?>

The first one isn't being executed because you're still in a string (the whole php tag and function call is appearing in your URL as a request variable). That's all I see from just looking at the code.