'su -' runs the profile of the user you change to - i.e. 'su - root' runs roots .profile. Just a normal 'su' without the dash doesn't run the profile.
Normally you would probably always do the 'su -', unless you don't want the profile for some specific reason (like it automatically runs an application, etc.)