Solved. Thanks people.

[HAL9000]

Hey people,

How do you write a JavaScript function to check if item is bigger an a but less than b?

Thanks in advance.

Neckarb

 

[MrChad]

function neckarb(value){
....return (value > a && value < b);
}

 

[Cogman]

function test(val)
{
   return (val > a) ? ((val < b) ? true : false) : false;
}

This is obviously the best solution.

an alternative would be

function test(val)
{
   var output = (a - val) * (val - b) > 0;
   return output
}

 

[ivan2]

how is that the best solution (implies it is better than Mr Chad's solution). when it detects val > a to be false it doesn't even go on with value < b, it is unnecessary to do all the low level optimization.

it's the same...

 

[HAL9000]

ok great thanks guys, the first solution works, but for some reason I can only get it to work if the values are not the results of prompts? I.e. If I assign the value it works fine, but if I have a prompt to assign the values to the variables it doesn't work?

Any ideas?

I.e. I'm trying to do this:

Result = value > bottom_range && value < top_range

after two prompts for bottom_range and top_range

bottom_range = prompt (); top_range = prompt ();

 

[Cogman]

how is that the best solution (implies it is better than Mr Chad's solution). when it detects val > a to be false it doesn't even go on with value < b, it is unnecessary to do all the low level optimization.

it's the same...

I was being facetious.

 

[HAL9000]

Slight update, it does work with a prompt, but it displays the wrong results for example the result will show 12500 is Greater than 10, but less than 50,000

Similarly if I input 10 as the bottom and 1000 as the top no results will be displayed.

These problems only occur when prompting for the values?

Suggestions?

 

[Crusty]

I'm not intimately familiar with JS but I would be checking for overflows and possible type mismatches as a cause for your problem now.

 

[MrChad]

Slight update, it does work with a prompt, but it displays the wrong results for example the result will show 12500 is Greater than 10, but less than 50,000

Similarly if I input 10 as the bottom and 1000 as the top no results will be displayed.

These problems only occur when prompting for the values?

Suggestions?

Do a parseInt() on the values returned from the prompt when doing the compare. You'll want some validation to ensure the user enters a numeric value.

 

[HAL9000]

Do a parseInt() on the values returned from the prompt when doing the compare. You'll want some validation to ensure the user enters a numeric value.

OK can I include parseInt in the comparison I listed?

 

[HAL9000]

scrap that got it cheers team!

 

[GodlessAstronomer]

**content removed**

Keep your posts on topic, and please refrain from negative editorializing about the content of other people's threads. There are plenty of forums on this board where that passes, but this isn't one of them.

Markbnj
Programming moderator