I hope this will clear some things up and help out your design.
The main() function should be your test driver code. I updated yours but left out the the information gathering part.
(I did this on the fly so no guarantees it will work)
🙂
#include <other includes you need>
#include SavingsAcount
int main()
{
SavingsAccount my_accounts[TEN]; // An array of ten savings accounts
int i = 0;
char cProceed = "y";
while ((cProceed=='y'||cProceed=='Y') && (i < 10)
{
cout<<"Do you want to continue? (Y,y/N,n): ";
cin>>cProceed;
if (cProceed=='y'||cProceed=='Y')
{
// Get information to populate BankAccount and SavingsAccount
my_Account.Apply(<varibles for BankAccount and SavingsAccount>;
}
else
{
cout<<"Please enter only y,Y or n,N. "<<endl;
}
i++;
}
for (int j ; j <= i; j++)
{
my_account[j].ShowInfo();
}
return 0;
}
Question: Why do you have both a ISavingsBal and NewSavingsBal? In the end there is only one balance for each account.
Question: Why did you put the balance in SavingsAccount? What if you made a CheckingAccount? A balance could be moved
to BankAccount since it is common to different types of accounts. A derived class should extend the functionality
that is different from the base class.
Question: How about a virtural member function to "Apply" a class "Transaction" to a SavingsAccount. In SavingsAccount
you will also have define a virtural memberfunction "Apply". "Apply" will add to or subtract from the ballance.
"Transaction" will know if this transaction is a deposit or a withdrawl. I added Apply to you classes.
The hierarchy of the derived classed:
BankAccount
SavingsAccount
CheckingAccount
MoneyMarketAccount
To declare a SavingsAccount in you main/Testing program
SavingsAccount my_savings; // Since it is a derived class it has all of the parts of SavingsAccount and BankAcount.
There is another way to do this
BankAccount *BankPtr = new SavingsAccount(); // Same thing but it is a pointer to a BankAccount that also has the
// parts of a SavingsAccount
Classes should be simple and only do what they have to do to benefit the class.
Constructors should do the following:
1) Initialize all class variables
2) Verify data ranges
3) Translate from an outside representation to an internal one. If what was passed in was a integer and the internal is a
pointer to a string then you need to code the conversion routine.
4) Allocate resources?.The internal representation is a dynamically allocated array.
BankAccount::GetInfo() is a bad design. A class should only know how to store and retrive information. You have
made a member function that takes on the job of collecting information to populate itself.
BankAccount::Exit() is also a bad idea since it does nothing for the class BankAcount.
Note: BankAccount: The default constructor needs to initalize all of the variables in BankAccount
BankAccount: Needs another constructor to be able to populate all variables in BankAccount at one time.
File BankAcount.h...Just the class definition
#ifndef BankAccount_h
#define BankAccount_h
class BankAccount
{
public:
char cFname; //First name
char cLname; //Last name
int iIDNumber; //Their ID number
public:
BankAccount();
virtual ~BankAccount(); // Virtual destructor so we clean this up when
// program exits
virtual void Exit();
virtual void ShowInfo(BankAccount Bank[], SavingsAccount Interest[],int);
virtual void GetInfo(BankAccount *Bank, SavingsAccount *Interest);
virtual void CalculateInfo(SavingsAccount *Iinterest);
virtual bool Apply(const Transaction& transaction) = 0;
};
#endif //BankAcount_h
In file BankAccount.cpp all of the member functions that operate on a BankAccount.
BankAccount::BankAccount()
{
char cFName [ARY];
char cLName [ARY];
int iIDNumber = NULL;
}
void BankAccount::CalculateInfo(SavingsAccount *Iinterest)
{
Iinterest->dNewSavingsBal += Iinterest->lSavingsBal * (Iinterest->fInterest/12);
}
void BankAccount::ShowInfo(BankAccount Bank[], SavingsAccount Interest[],int Iindex)
{
for (int iRunMe = NULL;iRunMe<Iindex;iRunMe++)
{
cout<<"Client's first name: "<<Bank[iRunMe].cFname<<endl;
cout<<"Client's last name: "<<Bank[iRunMe].cLname<<endl;
cout<<"Client's identification number: "<<Bank[iRunMe].iIDNumber<<endl;
cout<<"Interest rate: "<<Interest[iRunMe].fInterest<<endl;
cout<<"Current savings balance: "<<Interest[iRunMe].lSavingsBal<<endl;
cout<<"After monthly interest: "<<Interest[iRunMe].dNewSavingsBal<<endl;
}
}
In the file SavingsAccount.h
NOTE: You need to code up the member functions to access these private variables.
SavingsAccount: The default constructor needs to initalize all of the variables in SavingsAccount
SavingsAccount: Needs another constructor to be able to populate all variables in SavingsAccount at once.
#include "BankAccount.h"
#ifndef "SavingsAccount_h"
#define SavingsAccount_h"
class SavingsAccount: public BankAccount //added public to this line
{
private:
float fInterest;
long lSavingsBal;
double dNewSavingsBal;
float fMonthlyInterest;
public:
SavingsAccount();
virtual bool Apply(const Transaction& transaction); // Did this Transaction succeed?
};
#endif //SavingsAccount
In file SavingsAccount.cpp put all the Constructors and member functions to SavingsAccount/
SavingsAccount::SavingsAccount() :
BankAccount() // This calls the default constructor for BankAccount
{
// Initialize SavingsAccount variables
fInterest = 0;
lSavingsBal = 0;
lNewSavingsBal = 0;
fMonthlyInterest = 0;
}
// this is an example
//Second constructor called an Initializing Constructor V V V
SavingsAccount::SavingsAccount( <Put all variables for SavingsAccount and BankAccount here> float f_interest; ) :
BankAccount( <BankAccount variables> ) // This calls the Initializing constructor for BankAccount
{
// Initialize SavingsAccount variables
fInterest = f_interest; // example used here
lSavingsBal = <i_savingsbal>;
lNewSavingsBal = ;
fMonthlyInterest = ;
}
