C++ program

[Fandango21]

Hey everyone. Its that time of year again and I'm back in school. Been a few months since I last wrote any code and I'm trying to refresh a bit. Currently this is what I have but for some reason the program wants to ask the question twice before just displaying the result. I would like to have it to continue a loop if the user puts a number in less than one but as soon as they put in 1 or higher I want it to just return the value, not ask again for the number. This was written using Visual Studio C++.

#include <iostream>

using namespace std;

int numEmployees() {
	
	int number;
	cout << "Please enter the number of employees in the company. " << endl;
	cin >> number;
		while (number < 1) {
			cout << "The number of employees cannot be less than 1." << endl;
			cout << endl;
			cout << "Please enter the number of employees in the company. " << endl;
			cin >> number;
			}
	
	return number; 
}

int main () {
	
	numEmployees();
	
	cout << numEmployees() << endl;

	system("pause");
	return 0;

}

 

[Crusty]

You are calling numEmployees() twice.

 

[YoungGun21]

I'm not 100% sure, but I don't think you want to use a while loop.

Maybe you could do like if(number < 1){blah} else {......}

 

[Fandango21]

Lol. Wow. Thanks for noticing Crusty. To YoungGun21, I tried the if statement instead of while loop to see it in action and like I thought it does run a second time when the number < 1, however I need to to repeat over and over until the number is anything > 1 so I'm using the while loop. The If statement will only execute once basically.

 

[Fallen Kell]

Also for sanity, you might want to change your "int number" to a "string myinput", and then actually do a test that it is indeed a number, since "cin" doesn't care at all if you typed a number or not and your setting of an asci character into an int can and will cause some havoc. Doing that, you can then use "sstream" to validate if your string is a number safely. Personally, I would use "getline(cin, myinput)" instead of just cin.

 

[Fandango21]

Yea, Kell I ran into that very problem when I accidentally hit a letter. It made the program go ape sh*t lol. I get what you're saying by using a string and the getline approach kind of. We've only really barely talked about it to this point and I've never used sstream before. Also, the function has to return an int so that was my logic there (obviously flawed somewhat) Guess I could just static_cast the return? I'd like to use this and will probably look it up myself and mess around with it later. Thanks for the info

 

[Fallen Kell]

Well, reading in and returning are really two different things. It is perfectly fine to read in as a string, and after a verification that what you read in was indeed an integer, convert the string to an integer and then return the integer.

That said, I will send you to a little tutorial on sstream (or in long form StringStream):

http://www.cplusplus.com/doc/tutorial/basic_io/